netdev - RE: Add PHC support with error bound value for ENA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ff61605e6424624b252cbbc2f9cbe4f@amazon.com>
Date: Thu, 1 Feb 2024 18:56:04 +0000
From: "Bernstein, Amit" <amitbern@...zon.com>
To: Richard Cochran <richardcochran@...il.com>
CC: "tglx@...utronix.de" <tglx@...utronix.de>, "kuba@...nel.org"
	<kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Dagan,
 Noam" <ndagan@...zon.com>, "Arinzon, David" <darinzon@...zon.com>, "Agroskin,
 Shay" <shayagr@...zon.com>
Subject: RE: Add PHC support with error bound value for ENA driver

> On Thu, Feb 01, 2024 at 07:24:51AM +0000, Bernstein, Amit wrote:
> 
> > In one of the upcoming releases, we're planning to add PHC support to
> > the ENA driver (/drivers/net/ethernet/amazon/ena/) To provide the best
> > experience for service customers, the ENA driver will expose an
> > error_bound parameter (expressed in nanoseconds), which will represent
> > the maximal clock error on each given PHC timestamp.
> 
> > As our device sends each PHC timestamp with an error_bound value
> > together, gettimex64 is the reasonable option for us and our
> > recommended solution.  We would like to ask for your recommendation.
> 
> Sounds like gettimex64 won't help you.
> 
> You will need to extend the socket time stamping API.  That is how time
> stamps are delivered to user space.
> 
> HTH,
> Richard

Richard, thank you for your response.
However, I forgot to mention that the ENA driver currently doesn't support any socket timestamping.
It only supports the PTP hardware clock infrastructure, which is exported using the clock driver.
User space programs can control the clock driver via the PTP_SYS_OFFSET ioctl.
Therefore, we can only use the basic clock operations of ptp_clock_info, such as gettime/gettime64/gettimex64.

Thanks,
Amit