netdev - RE: [PATCH net-next 2/2] nfp: customize the dim profiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 1 Feb 2024 02:16:50 +0000
From: Yinjun Zhang <yinjun.zhang@...igine.com>
To: Jiri Pirko <jiri@...nulli.us>, Louis Peens <louis.peens@...igine.com>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Fei Qin <fei.qin@...hogine.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, oss-drivers
	<oss-drivers@...igine.com>
Subject: RE: [PATCH net-next 2/2] nfp: customize the dim profiles

On Wednesday, January 31, 2024 5:39 PM, Jiri Pirko wrote:
<...>
> It looks incorrect to hardcode it like this. There is a reason this is
> abstracted out in lib/dim/net_dim.c to avoid exactly this. Can't you
> perhaps introduce your modified profile there and keep using
> net_dim_get_[tr]x_moderation() helpers?
> 

We don't know if this introduced profile is adaptable to other NICs/vendors,
it's generated based on NFP's performance. Do you really think it's
appropriate to move it to the net_dim.c as a new common profile like:
enum dim_cq_period_mode {
        DIM_CQ_PERIOD_MODE_START_FROM_EQE = 0x0,
        DIM_CQ_PERIOD_MODE_START_FROM_CQE = 0x1,
+       DIM_CQ_PERIOD_MODE_SPECIFIC_0 = 0x2,
        DIM_CQ_PERIOD_NUM_MODES
 };