netdev - Re: [RFC PATCH v3 net-next] Documentation: devlink: Add devlink-sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bea046d-326e-4f32-b6cb-dd92811b5fcb@intel.com>
Date: Wed, 31 Jan 2024 20:23:44 -0600
From: "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, William Tu <witu@...dia.com>
CC: Jacob Keller <jacob.e.keller@...el.com>, <bodong@...dia.com>,
	<jiri@...dia.com>, <netdev@...r.kernel.org>, <saeedm@...dia.com>,
	"aleksander.lobakin@...el.com" <aleksander.lobakin@...el.com>, "Michal
 Swiatkowski" <michal.swiatkowski@...ux.intel.com>
Subject: Re: [RFC PATCH v3 net-next] Documentation: devlink: Add devlink-sd



On 1/31/2024 5:17 PM, Jakub Kicinski wrote:
> On Wed, 31 Jan 2024 15:02:58 -0800 William Tu wrote:
>>> I just did a grep on METADATA_HW_PORT_MUX and assumed bnxt, ice and nfp
>>> all do buffer sharing. You're saying you mux Tx queues but not Rx
>>> queues? Or I need to actually read the code instead of grepping? :)
>>
>> I guess bnxt, ice, nfp are doing tx buffer sharing?
> 
> I'm not familiar with ice. I'm 90% sure bnxt shares both Rx and Tx.
> I'm 99.9% sure nfp does.

In ice, all the VF representor netdevs share a VSI(TX/RX queues). UL/PF 
netdev has its own VSI and TX/RX queues. But there is patch from Michal 
under review that is going to simplify the design with a single VSI and 
all the VF representor netdevs and UL/PF netdev will be sharing the 
TX/RX queues in switchdev mode.

Does mlx5 has separate TX/RX queues for each of its representor netdevs?

> 
> It'd be great if you could do the due diligence rather than guessing
> given that you're proposing uAPI extension :(
> 
>> This devlink sd is for RX queues not TX queues.
>>
>> And devlink-sd creates a pool of shared descriptors only for RX queue.
>>
>> The TX queues/ TX path remain unchanged.
>