netdev - Re: Persistent problem with handshake unit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ad1ff9f-bf42-4a36-855f-8ae62931dd84@roeck-us.net>
Date: Fri, 2 Feb 2024 17:45:55 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>,
 kernel-tls-handshake@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: Persistent problem with handshake unit tests

On 2/2/24 16:47, Jakub Kicinski wrote:
> On Fri, 2 Feb 2024 12:51:07 -0800 Guenter Roeck wrote:
>>> I have CONFIG_NET_HANDSHAKE_KUNIT_TEST=y enabled in my configuration.
>>> The tests run during boot, so no additional work is needed. I don't run all
>>> tests because many take too long to execute in qemu.
> 
> I was wondering how do you discover the options. Periodically grep for
> new possible KUNIT options added to the kernel? Have some script that
> does it.
> 

"Periodically grep for > new possible KUNIT options added to the kernel"

Exactly, and see what happens if I enable them to determine if they run
fast and if they are stable enough to be enabled in a qemu test. I can not
enable tests automatically because some just take too long to run, as in

# takes too long
# enable_config "${fragment}" CONFIG_TEST_RHASHTABLE

or

# takes too long
# enable_config "${fragment}" CONFIG_TORTURE_TEST CONFIG_LOCK_TORTURE_TEST CONFIG_RCU_TORTURE_TEST

Sometimes I have to disable tests because a long-running sub-option is added,
as in

# CONFIG_MEMCPY_KUNIT_TEST sometimes takes more than 45 seconds.
# CONFIG_MEMCPY_SLOW_KUNIT_TEST avoids this, but last time I checked
# this was not present in all affected kernel branches.
# enable_config "${fragment} CONFIG_MEMCPY_KUNIT_TEST

or because of problems such as

# RTC library unit tests hang in many qemu emulations
# enable_config "${fragment}" CONFIG_RTC_LIB_KUNIT_TEST

or

# clock unit tests seem to introduce noise warning tracebacks
# enable_config "${fragment}" CONFIG_CLK_GATE_KUNIT_TEST CONFIG_CLK_KUNIT_TEST

or

# Results in lots of "ASoC: Parent card not yet available" log messages
# enable_config "${fragment}" CONFIG_SND_SOC_TOPOLOGY_KUNIT_TEST SND_SOC_UTILS_KUNIT_TEST

or

# CONFIG_WW_MUTEX_SELFTEST interferes with CONFIG_PREEMPT=y
# enable_config "${fragment}" CONFIG_WW_MUTEX_SELFTEST

or

# generates warning backtraces on purpose
# enable_config "${fragment}" CONFIG_OF_UNITTEST

Thanks,
Guenter

>> Follow-up: If this test isn't supposed to run during boot, please
>> let me know and I'll drop it.
> 
> FWIW I don't see why, but Chuck is the best person to comment.