netdev - Re: [PATCH v3 net-next 3/3] tools: ynl: add support for encoding multi-attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240202181755.292c165c@kernel.org>
Date: Fri, 2 Feb 2024 18:17:55 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Alessandro Marcolini <alessandromarcolini99@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 donald.hunter@...il.com, sdf@...gle.com, chuck.lever@...cle.com,
 lorenzo@...nel.org, jacob.e.keller@...el.com, jiri@...nulli.us,
 netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 3/3] tools: ynl: add support for encoding
 multi-attr

On Fri,  2 Feb 2024 15:00:05 +0100 Alessandro Marcolini wrote:
>          nl_type = attr.value
> +        if attr.is_multi and isinstance(value, list):
> +            attr_payload = b''
> +            for subvalue in value:
> +                attr_payload += self._add_attr(space, name, subvalue, search_attrs)
> +            return attr_payload
>          if attr["type"] == 'nest':

nit: would you mind adding an empty line before and after the new
block? It's logically separate from the other code, sort of an
alternative to the "actual" handling, as well as finding the attr set.

Also agreed on adding an example to the cover letter (either one or
both).

With that feel free to add:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

on all 3 patches in v4.