netdev - Re: [PATCH net-next] bnxt: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e65b8525-eae0-4143-aa57-009b47f09005@lunn.ch>
Date: Sat, 3 Feb 2024 22:59:14 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, David Miller <davem@...emloft.net>,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	Michael Chan <michael.chan@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bnxt: convert EEE handling to use linkmode
 bitmaps

> -	if (!edata->advertised_u32) {
> -		edata->advertised_u32 = advertising & eee->supported_u32;
> -	} else if (edata->advertised_u32 & ~advertising) {
> -		netdev_warn(dev, "EEE advertised %x must be a subset of autoneg advertised speeds %x\n",
> -			    edata->advertised_u32, advertising);

That warning text looks wrong. I think it should be

EEE advertised %x must be a subset of autoneg supported speeds %x

and it should print eee->supported, not advertising.

Lets leave that to Broadcom to fix.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew