netdev - Re: [PATCH net-next] bnxt: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d6e5d5d-66b4-4d7c-91b7-ac7aea30d5f9@gmail.com>
Date: Sun, 4 Feb 2024 00:05:59 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, David Miller <davem@...emloft.net>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Michael Chan <michael.chan@...adcom.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bnxt: convert EEE handling to use linkmode
 bitmaps

On 03.02.2024 22:59, Andrew Lunn wrote:
>> -	if (!edata->advertised_u32) {
>> -		edata->advertised_u32 = advertising & eee->supported_u32;
>> -	} else if (edata->advertised_u32 & ~advertising) {
>> -		netdev_warn(dev, "EEE advertised %x must be a subset of autoneg advertised speeds %x\n",
>> -			    edata->advertised_u32, advertising);
> 
> That warning text looks wrong. I think it should be
> 
> EEE advertised %x must be a subset of autoneg supported speeds %x
> 
> and it should print eee->supported, not advertising.
> 
> Lets leave that to Broadcom to fix.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
I just saw that I overlooked needed conversions, will send a v2.

>     Andrew
Heiner