netdev - Re: [PATCH net-next] bnxt: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinhkS8-=QtZu9Es9ATiSMAyosuCfuPVFUOxzqJk4Tr2rA@mail.gmail.com>
Date: Sat, 3 Feb 2024 16:16:51 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	David Miller <davem@...emloft.net>, Russell King - ARM Linux <linux@...linux.org.uk>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bnxt: convert EEE handling to use linkmode bitmaps

On Sat, Feb 3, 2024 at 1:59 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > -     if (!edata->advertised_u32) {
> > -             edata->advertised_u32 = advertising & eee->supported_u32;
> > -     } else if (edata->advertised_u32 & ~advertising) {
> > -             netdev_warn(dev, "EEE advertised %x must be a subset of autoneg advertised speeds %x\n",
> > -                         edata->advertised_u32, advertising);
>
> That warning text looks wrong. I think it should be
>
> EEE advertised %x must be a subset of autoneg supported speeds %x
>
> and it should print eee->supported, not advertising.
>
I think it is correct.  EEE advertised must be a subset of the
advertised speed.  Let's say we are only advertising 1G for speed,
then EEE must not advertise more than 1G.  Advertising for more than
1G doesn't make sense anyway because it will only link up at 1G.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)