netdev - Re: [patch net-next] dpll: check that pin is registered in __dpll_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef4a3a68-8415-41d3-81b7-b46976b61a82@linux.dev>
Date: Tue, 6 Feb 2024 10:18:15 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc: arkadiusz.kubalewski@...el.com
Subject: Re: [patch net-next] dpll: check that pin is registered in
 __dpll_pin_unregister()

On 06/02/2024 07:48, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Similar to what is done in dpll_device_unregister(), add assertion to
> __dpll_pin_unregister() to make sure driver does not try to unregister
> non-registered pin.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> ---
>   drivers/dpll/dpll_core.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
> index 61e5c607a72f..93c1bb7a6ef7 100644
> --- a/drivers/dpll/dpll_core.c
> +++ b/drivers/dpll/dpll_core.c
> @@ -29,6 +29,8 @@ static u32 dpll_pin_xa_id;
>   	WARN_ON_ONCE(!xa_get_mark(&dpll_device_xa, (d)->id, DPLL_REGISTERED))
>   #define ASSERT_DPLL_NOT_REGISTERED(d)	\
>   	WARN_ON_ONCE(xa_get_mark(&dpll_device_xa, (d)->id, DPLL_REGISTERED))
> +#define ASSERT_DPLL_PIN_REGISTERED(p) \
> +	WARN_ON_ONCE(!xa_get_mark(&dpll_pin_xa, (p)->id, DPLL_REGISTERED))
>   
>   struct dpll_device_registration {
>   	struct list_head list;
> @@ -631,6 +633,7 @@ static void
>   __dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin,
>   		      const struct dpll_pin_ops *ops, void *priv)
>   {
> +	ASSERT_DPLL_PIN_REGISTERED(pin);
>   	dpll_xa_ref_pin_del(&dpll->pin_refs, pin, ops, priv);
>   	dpll_xa_ref_dpll_del(&pin->dpll_refs, dpll, ops, priv);
>   	if (xa_empty(&pin->dpll_refs))

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>