netdev - RE: [patch net-next] dpll: check that pin is registered in __dpll_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB4657A65CFE8A638A933798589B452@DM6PR11MB4657.namprd11.prod.outlook.com>
Date: Wed, 7 Feb 2024 18:16:56 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jiri Pirko <jiri@...nulli.us>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>
Subject: RE: [patch net-next] dpll: check that pin is registered in
 __dpll_pin_unregister()

>From: Jiri Pirko <jiri@...nulli.us>
>Sent: Tuesday, February 6, 2024 8:49 AM
>
>From: Jiri Pirko <jiri@...dia.com>
>
>Similar to what is done in dpll_device_unregister(), add assertion to
>__dpll_pin_unregister() to make sure driver does not try to unregister
>non-registered pin.
>
>Signed-off-by: Jiri Pirko <jiri@...dia.com>
>---
> drivers/dpll/dpll_core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c
>index 61e5c607a72f..93c1bb7a6ef7 100644
>--- a/drivers/dpll/dpll_core.c
>+++ b/drivers/dpll/dpll_core.c
>@@ -29,6 +29,8 @@ static u32 dpll_pin_xa_id;
> 	WARN_ON_ONCE(!xa_get_mark(&dpll_device_xa, (d)->id, DPLL_REGISTERED))
> #define ASSERT_DPLL_NOT_REGISTERED(d)	\
> 	WARN_ON_ONCE(xa_get_mark(&dpll_device_xa, (d)->id, DPLL_REGISTERED))
>+#define ASSERT_DPLL_PIN_REGISTERED(p) \
>+	WARN_ON_ONCE(!xa_get_mark(&dpll_pin_xa, (p)->id, DPLL_REGISTERED))
>
> struct dpll_device_registration {
> 	struct list_head list;
>@@ -631,6 +633,7 @@ static void
> __dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin,
> 		      const struct dpll_pin_ops *ops, void *priv)
> {
>+	ASSERT_DPLL_PIN_REGISTERED(pin);
> 	dpll_xa_ref_pin_del(&dpll->pin_refs, pin, ops, priv);
> 	dpll_xa_ref_dpll_del(&pin->dpll_refs, dpll, ops, priv);
> 	if (xa_empty(&pin->dpll_refs))
>--
>2.43.0

LGTM, Thank you!

Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>