lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240207101934.6c0ab20b@kernel.org>
Date: Wed, 7 Feb 2024 10:19:34 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Abhishek Chauhan <quic_abchauha@...cinc.com>, Vinod Koul
 <vkoul@...nel.org>, Bhupesh Sharma <bhupesh.sharma@...aro.org>, Andy Gross
 <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio
 <konrad.dybcio@...aro.org>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
 Prasad Sodagudi <psodagud@...cinc.com>, Andrew Halaney
 <ahalaney@...hat.com>, Rob Herring <robh@...nel.org>, <kernel@...cinc.com>
Subject: Re: [PATCH v2] net: stmmac: dwmac-qcom-ethqos: Enable TBS on all
 queues but 0

On Wed, 7 Feb 2024 09:26:05 -0800 Jeff Johnson wrote:
> > This is similar to the patch raised by NXP <3b12ec8f618e>
> > <"net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings">  
> 
> note that there is a standard way to refer to a prior patch, in your case:
> 3b12ec8f618e ("net: stmmac: dwmac-imx: set TSO/TBS TX queues default
> settings")

Yes, please fix.

> (note this format is defined in the context of the Fixes tag at
> <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>)

A fixes tag would be great. But we can't point at 3b12ec8f618e, right?
Can someone explain what the user-visible problem is?
TBS cannot be used? Device reinit is require to enable it?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ