netdev - Re: [PATCH net-next v2] selftests: udpgso: Pull up network setup into shell script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207102410.7062dcb0@kernel.org>
Date: Wed, 7 Feb 2024 10:24:10 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jakub Sitnicki <jakub@...udflare.com>
Cc: netdev@...r.kernel.org, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 kernel-team@...udflare.com
Subject: Re: [PATCH net-next v2] selftests: udpgso: Pull up network setup
 into shell script

On Tue, 06 Feb 2024 19:58:31 +0100 Jakub Sitnicki wrote:
> +setup_loopback() {
> +  ip addr add dev lo 10.0.0.1/32
> +  ip addr add dev lo fd00::1/128 nodad noprefixroute
> +}

Can I nit pick on stupid stuff?
Quick look at other udpg*s*.sh scripts indicates we use tabs
for indent. IDK what the rules should be but I have an uneducated
feeling that 2 spaces are quite rare.