netdev - Re: [PATCH net-next] net: atlantic: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba71c38d-23ad-4e78-bb34-ea383ba8d13e@lunn.ch>
Date: Wed, 7 Feb 2024 17:14:26 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	David Miller <davem@...emloft.net>,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	Igor Russkikh <irusskikh@...vell.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: atlantic: convert EEE handling to use
 linkmode bitmaps

On Wed, Feb 07, 2024 at 07:53:14AM -0800, Jakub Kicinski wrote:
> On Wed, 7 Feb 2024 07:52:49 +0100 Heiner Kallweit wrote:
> > > This is again a correct translation. But the underlying implementation
> > > seems wrong. aq_ethtool_set_eee() does not appear to allow the
> > > advertisement to be changed, so advertised does equal
> > > supported. However aq_ethtool_set_eee() does not validate that the
> > > user is not changing what is advertised and returning an error. Lets
> > > leave it broken, and see if Aquantia/Marvell care.
> > > 
> > > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> > 
> > This patch was by mistake set to "Changes requested".
> 
> It's because of the comment about zeroing, not the latter one.
> 
> Sorry, it's impossible for me to guess whether he meant the tag
> for v2 or he's fine with the patch as is. Andrew has the powers
> to change pw state, I'm leaving this to him.

Hi Heiner

Sorry, i was not explicitly. The linkmode_zero() is not needed, so it
would be good to remove it. Then feel free to add my Reviewed-by:

      Andrew