netdev - Re: [PATCH net-next] net: atlantic: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207075314.5458bd68@kernel.org>
Date: Wed, 7 Feb 2024 07:53:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>, Russell King - ARM Linux
 <linux@...linux.org.uk>, Igor Russkikh <irusskikh@...vell.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Andrew Lunn
 <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: atlantic: convert EEE handling to use
 linkmode bitmaps

On Wed, 7 Feb 2024 07:52:49 +0100 Heiner Kallweit wrote:
> > This is again a correct translation. But the underlying implementation
> > seems wrong. aq_ethtool_set_eee() does not appear to allow the
> > advertisement to be changed, so advertised does equal
> > supported. However aq_ethtool_set_eee() does not validate that the
> > user is not changing what is advertised and returning an error. Lets
> > leave it broken, and see if Aquantia/Marvell care.
> > 
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> This patch was by mistake set to "Changes requested".

It's because of the comment about zeroing, not the latter one.

Sorry, it's impossible for me to guess whether he meant the tag
for v2 or he's fine with the patch as is. Andrew has the powers
to change pw state, I'm leaving this to him.