netdev - Re: [PATCH net-next] net: atlantic: convert EEE handling to use linkmode bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2046e53a-6de4-41e0-b816-3e7926ad489b@gmail.com>
Date: Wed, 7 Feb 2024 07:52:49 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>
Cc: Russell King - ARM Linux <linux@...linux.org.uk>,
 Igor Russkikh <irusskikh@...vell.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: atlantic: convert EEE handling to use
 linkmode bitmaps

On 03.02.2024 22:50, Andrew Lunn wrote:
> On Sat, Feb 03, 2024 at 10:25:44PM +0100, Heiner Kallweit wrote:
>> Convert EEE handling to use linkmode bitmaps. This prepares for
>> removing the legacy bitmaps from struct ethtool_keee.
>> No functional change intended.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> ---
> [...]
> 
> This is again a correct translation. But the underlying implementation
> seems wrong. aq_ethtool_set_eee() does not appear to allow the
> advertisement to be changed, so advertised does equal
> supported. However aq_ethtool_set_eee() does not validate that the
> user is not changing what is advertised and returning an error. Lets
> leave it broken, and see if Aquantia/Marvell care.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 

This patch was by mistake set to "Changes requested". As Andrew mentions
in his review comment, the patch is a mechanical change, and it's fine.
It's a different story that the underlying implementation it's broken.
This should be fixed separately.

Same applies to "bnx2x: convert EEE handling to use linkmode bitmaps"

>     Andrew