netdev - Re: [PATCH net-next v6 4/4] eventpoll: Add epoll ioctl for epoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240207121844.6bf34083@kernel.org>
Date: Wed, 7 Feb 2024 12:18:44 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 chuck.lever@...cle.com, jlayton@...nel.org, linux-api@...r.kernel.org,
 brauner@...nel.org, edumazet@...gle.com, davem@...emloft.net,
 alexander.duyck@...il.com, sridhar.samudrala@...el.com,
 willemdebruijn.kernel@...il.com, weiwan@...gle.com,
 David.Laight@...LAB.COM, arnd@...db.de, sdf@...gle.com,
 amritha.nambiar@...el.com, Jonathan Corbet <corbet@....net>, Alexander Viro
 <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, Nathan Lynch
 <nathanl@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Namjae Jeon
 <linkinjeon@...nel.org>, Steve French <stfrench@...rosoft.com>, Thomas
 Zimmermann <tzimmermann@...e.de>, Julien Panis <jpanis@...libre.com>,
 Andrew Waterman <waterman@...s.berkeley.edu>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, "open
 list:DOCUMENTATION" <linux-doc@...r.kernel.org>, "open list:FILESYSTEMS
 (VFS and infrastructure)" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH net-next v6 4/4] eventpoll: Add epoll ioctl for
 epoll_params

On Wed, 7 Feb 2024 11:16:03 -0800 Joe Damato wrote:
> > > netdev maintainers: Jiri marked this with Reviewed-by, but was this review
> > > what caused "Changes Requested" to be the status set for this patch set in
> > > patchwork?
> > > 
> > > If needed, I'll send a v7 with the changes Jiri suggested and add the
> > > "Reviewed-by" since the changes are cosmetic, but I wanted to make sure
> > > this was the reason.  
> > 
> > Yes, I think that's it.  
> 
> OK, thanks for letting me know. I wasn't sure if it was because of the
> netdev/source_inline which marked 1/4 as "fail" because of the inlines
> added.
> 
> Does that need to be changed, as well?

For background our preference is to avoid using static inline in C
sources, unless the author compiled the code and actually confirmed
the code doesn't get inlined correctly. But it's not a hard
requirement, and technically the code is under fs/.

In general the patchwork checks are a bit noisy, see here the top left
graph of how many of the patches we merge are "all green":
https://netdev.bots.linux.dev/checks.html
Some of the checks are also largely outside of our control (checkpatch)
so consider the patchwork checks as automation for maintainers. 
The maintainers should respond on the list if any of the failures 
are indeed legit.