netdev - RE: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ice: Remove and readd netdev during devlink reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 17:03:53 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Drewek, Wojciech" <wojciech.drewek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>,
	"bcreeley@....com" <bcreeley@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Stillwell Jr, Paul M"
	<paul.m.stillwell.jr@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ice: Remove and readd
 netdev during devlink reload

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Wojciech Drewek
> Sent: Monday, February 5, 2024 6:34 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: vadim.fedorenko@...ux.dev; bcreeley@....com; netdev@...r.kernel.org; Stillwell Jr, Paul M <paul.m.stillwell.jr@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; jiri@...nulli.us
> Subject: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ice: Remove and readd netdev during devlink reload
>
> Recent changes to the devlink reload (commit 9b2348e2d6c9
> ("devlink: warn about existing entities during reload-reinit"))
> force the drivers to destroy devlink ports during reinit.
> Adjust ice driver to this requirement, unregister netdvice, destroy
> devlink port. ice_init_eth() was removed and all the common code
> between probe and reload was moved to ice_load().
>
> During devlink reload we can't take devl_lock (it's already taken)
> and in ice_probe() we have to lock it. Use devl_* variant of the API
> which does not acquire and release devl_lock. Guard ice_load()
> with devl_lock only in case of probe.
>
> Suggested-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
> v2: empty init removed in ice_devlink_reinit_up
> v3: refactor locking pattern as Brett suggested
> v4: fix wrong function name in commit message
> v5: move debugfs changes to separate commit
> ---
>  drivers/net/ethernet/intel/ice/ice.h         |   2 +
>  drivers/net/ethernet/intel/ice/ice_devlink.c |  68 ++++++-
>  drivers/net/ethernet/intel/ice/ice_main.c    | 186 ++++++-------------
>  3 files changed, 125 insertions(+), 131 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)