netdev - RE: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Fix debugfs with devlink reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 8 Feb 2024 17:06:01 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Drewek, Wojciech" <wojciech.drewek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>,
	"bcreeley@....com" <bcreeley@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Stillwell Jr, Paul M"
	<paul.m.stillwell.jr@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Fix debugfs with
 devlink reload

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Wojciech Drewek
> Sent: Monday, February 5, 2024 6:34 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: vadim.fedorenko@...ux.dev; bcreeley@....com; netdev@...r.kernel.org; Stillwell Jr, Paul M <paul.m.stillwell.jr@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; jiri@...nulli.us
> Subject: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Fix debugfs with devlink reload
>
> During devlink reload it is needed to remove debugfs entries
> correlated with only one PF. ice_debugfs_exit() removes all
> entries created by ice driver so we can't use it.
>
> Introduce ice_debugfs_pf_deinit() in order to release PF's
> debugfs entries. Move ice_debugfs_exit() call to ice_module_exit(),
> it makes more sense since ice_debugfs_init() is called in
> ice_module_init() and not in ice_probe().
>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice.h         |  1 +
>  drivers/net/ethernet/intel/ice/ice_debugfs.c | 10 ++++++++++
>  drivers/net/ethernet/intel/ice/ice_fwlog.c   |  2 ++
>  drivers/net/ethernet/intel/ice/ice_main.c    |  3 +--
>  4 files changed, 14 insertions(+), 2 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)