netdev - Re: [PATCH] m_action: Fix descriptor leak in get_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240208090540.08537135@hermes.local>
Date: Thu, 8 Feb 2024 09:05:40 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Maks Mishin <maks.mishinfz@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] m_action: Fix descriptor leak in get_action_kind()

On Thu,  8 Feb 2024 00:16:32 +0300
Maks Mishin <maks.mishinfz@...il.com> wrote:

> Found by RASU JSC
> 
> Signed-off-by: Maks Mishin <maks.mishinFZ@...il.com>
> ---
>  tc/m_action.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tc/m_action.c b/tc/m_action.c
> index 16474c56..7d18f7fa 100644
> --- a/tc/m_action.c
> +++ b/tc/m_action.c
> @@ -111,6 +111,9 @@ restart_s:
>  
>  	snprintf(buf, sizeof(buf), "%s_action_util", str);
>  	a = dlsym(dlh, buf);
> +	if (dlh != NULL)
> +		dlclose(dlh);
> +
>  	if (a == NULL)
>  		goto noexist;
>  

NAK again, this will break the caching