netdev - Re: [PATCH net-next v3] net: fec: Refactor: #define magic constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <655a090c-fc37-4596-a77c-bc55a5ccbd68@lunn.ch>
Date: Fri, 9 Feb 2024 14:56:30 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Csókás Bence <csokas.bence@...lan.hu>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>,
	Clark Wang <xiaoning.wang@....com>,
	NXP Linux Team <linux-imx@....com>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Denis Kirjanov <dkirjanov@...e.de>
Subject: Re: [PATCH net-next v3] net: fec: Refactor: #define magic constants

On Fri, Feb 09, 2024 at 11:01:33AM +0100, Csókás Bence wrote:
> Add defines for bits of ECR, RCR control registers, TX watermark etc.

Another guideline which we have for networking. Wait for at least 24
hours before posting a new version. I just wasted time reviewing an
old version.

Please make sure you address all the comments on the older version.


    Andrew

---
pw-bot: cr