netdev - Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68d61c24-b6d3-450a-8976-e87beb9b54e3@kernel.org>
Date: Fri, 9 Feb 2024 14:57:13 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Maxim Galaganov <max@...ernet.ru>,
 Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: Linux Kernel Functional Testing <lkft@...aro.org>,
 netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 Mat Martineau <martineau@...nel.org>
Subject: Re: [PATCH net] selftests: net: ip_local_port_range: define
 IPPROTO_MPTCP

Hi Maxim, Naresh,

On 09/02/2024 14:25, Maxim Galaganov wrote:
> Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> building ip_local_port_range.c, that leads to "error: use of undeclared
> identifier 'IPPROTO_MPTCP'".
> 
> Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
> 
> Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> Signed-off-by: Maxim Galaganov <max@...ernet.ru>

Thank you both for the fix and the bug report!

Acked-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.