netdev - Re: [PATCH] iproute2: fix build failure on ppc64le

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3730d7e4-058f-421f-8ecf-a9475440ef58@gmail.com>
Date: Fri, 9 Feb 2024 15:14:28 -0700
From: David Ahern <dsahern@...il.com>
To: Stephen Hemminger <stephen@...workplumber.org>,
 Andrea Claudi <aclaudi@...hat.com>
Cc: netdev@...r.kernel.org, sgallagh@...hat.com
Subject: Re: [PATCH] iproute2: fix build failure on ppc64le

On 2/9/24 9:35 AM, Stephen Hemminger wrote:
> On Fri,  9 Feb 2024 11:24:47 +0100
> Andrea Claudi <aclaudi@...hat.com> wrote:
> 
>> ss.c:3244:34: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka ‘long unsigned int’} [-Wformat=]
>>  3244 |                 out(" rcv_nxt:%llu", s->mptcpi_rcv_nxt);
>>       |                               ~~~^   ~~~~~~~~~~~~~~~~~
>>       |                                  |    |
>>       |                                  |    __u64 {aka long unsigned int}
>>       |                                  long long unsigned int
>>       |                               %lu
>>
>> This happens because __u64 is defined as long unsigned on ppc64le.  As
>> pointed out by Florian Weimar, we should use -D__SANE_USERSPACE_TYPES__
>> if we really want to use long long unsigned in iproute2.
> 
> Ok, this looks good.
> Another way to fix would be to use the macros defined in inttypes.h
> 
> 		out(" rcv_nxt:"PRIu64, s->mptcpi_rcv_nxt);
> 

since the uapi is __u64, I think this is the better approach.