netdev - Re: [PATCH iproute2 v2] tc: Add support json option in filter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240210170055.30fcea14@hermes.local>
Date: Sat, 10 Feb 2024 17:00:55 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Takanori Hirano <me@...tknr.net>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2] tc: Add support json option in filter.

On Sat, 10 Feb 2024 10:08:03 +0000
Takanori Hirano <me@...tknr.net> wrote:

>  	}
> +	if (tb[TCA_FLOW_MODE]) {
> +		close_json_object();
> +	}
>  	return 0;
>  }

This last bit is problematic, the JSON encoding should not change
based on whether flow mode is present or not.

Also, brackets not needed around single statement