netdev - Re: [PATCH iproute2 v2] tc: Add support json option in filter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0106018d95b5d2c4-b1827da3-cb5d-4660-98f4-d6d7c4e39db0-000000@ap-northeast-1.amazonses.com>
Date: Sun, 11 Feb 2024 01:08:57 +0000
From: Takanori Hirano <me@...tknr.net>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2] tc: Add support json option in filter.

On Sat, Feb 10, 2024 at 05:00:55PM -0800, Stephen Hemminger wrote:
> On Sat, 10 Feb 2024 10:08:03 +0000
> Takanori Hirano <me@...tknr.net> wrote:
> 
> >  	}
> > +	if (tb[TCA_FLOW_MODE]) {
> > +		close_json_object();
> > +	}
> >  	return 0;
> >  }
> 
> This last bit is problematic, the JSON encoding should not change
> based on whether flow mode is present or not.
> 
> Also, brackets not needed around single statement
Thanks for the review. Yes, I agree with that.
In the v2 patch, it was present because I was using open_json_object to open the map/hash.
In the latest patch I just sent you, it has been moved to the "mode" key.
I have also removed the close section because it does not do json open.