netdev - Re: [PATCH net 2/2] igc: Remove temporary workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 11 Feb 2024 08:53:36 +0200
From: Sasha Neftin <sasha.neftin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<netdev@...r.kernel.org>, Paul Menzel <pmenzel@...gen.mpg.de>, Naama Meir
	<naamax.meir@...ux.intel.com>, "Neftin, Sasha" <sasha.neftin@...el.com>,
	"Ruinskiy, Dima" <dima.ruinskiy@...el.com>
Subject: Re: [PATCH net 2/2] igc: Remove temporary workaround

On 09/02/2024 4:33, Jakub Kicinski wrote:
> On Tue,  6 Feb 2024 13:28:18 -0800 Tony Nguyen wrote:
>> From: Sasha Neftin <sasha.neftin@...el.com>
>>
>> PHY_CONTROL register works as defined in the IEEE 802.3 specification
>> (IEEE 802.3-2008 22.2.4.1). Tide up the temporary workaround.
> 
> Any more info on this one?
> What's the user impact?
> What changed (e.g. which FW version fixed it)?

User impact: PHY could be powered down when the link is down (ip link 
set down <device>)

Fix by PHY firmware and deployed via OEM updates (automatically, with 
OEM SW/FW updates). We checked the IEEE behavior and removed w/a.

The PHY vendor no longer works with Intel, but I can say this was fixed 
on a very early silicon step (years ago).