netdev - Re: [PATCH net 2/2] igc: Remove temporary workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240212090846.18c517fc@kernel.org>
Date: Mon, 12 Feb 2024 09:08:46 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sasha Neftin <sasha.neftin@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>, Paul
 Menzel <pmenzel@...gen.mpg.de>, Naama Meir <naamax.meir@...ux.intel.com>,
 "Ruinskiy, Dima" <dima.ruinskiy@...el.com>
Subject: Re: [PATCH net 2/2] igc: Remove temporary workaround

On Sun, 11 Feb 2024 08:53:36 +0200 Sasha Neftin wrote:
> > Any more info on this one?
> > What's the user impact?
> > What changed (e.g. which FW version fixed it)?  
> 
> User impact: PHY could be powered down when the link is down (ip link 
> set down <device>)

to make it a tiny bit clearer:

s/could/can now/ ?
s/link is down/device is down/ ?
 
> Fix by PHY firmware and deployed via OEM updates (automatically, with 
> OEM SW/FW updates). We checked the IEEE behavior and removed w/a.
> 
> The PHY vendor no longer works with Intel, but I can say this was fixed 
> on a very early silicon step (years ago).

And the versions of the PHY components are not easily accessible so we
can't point to the version that was buggy or at least the oldest you
tested? If that's the case - it is what it is, please repost with the
improved commit msg.