netdev - Re: [Intel-wired-lan] [PATCH iwl-next v3] igc: Add support for LEDs on i225/i226

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa9a43d6-6558-4af6-9a7b-2e35341c179c@linux.intel.com>
Date: Mon, 12 Feb 2024 13:57:10 +0200
From: "naamax.meir" <naamax.meir@...ux.intel.com>
To: Kurt Kanzenbach <kurt@...utronix.de>,
 Jesse Brandeburg <jesse.brandeburg@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc: Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Eric Dumazet <edumazet@...gle.com>, intel-wired-lan@...ts.osuosl.org,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] igc: Add support for LEDs
 on i225/i226

On 2/6/2024 16:27, Kurt Kanzenbach wrote:
> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> from user space using the netdev trigger. The LEDs are named as
> igc-<bus><device>-<led> to be easily identified.
> 
> Offloading link speed and activity are supported. Other modes are simulated
> in software by using on/off. Tested on Intel i225.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
> Changes since v2:
> 
>   * Offload activity if possible (Andrew)
> 
> Changes since v1:
> 
>   * Add brightness_set() to allow software control (Andrew)
>   * Remove offloading of activity, because the software control is more flexible
>   * Fix smatch warning (Simon)
> 
> Previous versions:
> 
>   * v1: https://lore.kernel.org/netdev/20240124082408.49138-1-kurt@linutronix.de/
>   * v2: https://lore.kernel.org/netdev/20240201125946.44431-1-kurt@linutronix.de/
> ---
>   drivers/net/ethernet/intel/Kconfig        |   8 +
>   drivers/net/ethernet/intel/igc/Makefile   |   1 +
>   drivers/net/ethernet/intel/igc/igc.h      |   5 +
>   drivers/net/ethernet/intel/igc/igc_leds.c | 280 ++++++++++++++++++++++++++++++
>   drivers/net/ethernet/intel/igc/igc_main.c |   6 +
>   drivers/net/ethernet/intel/igc/igc_regs.h |   1 +
>   6 files changed, 301 insertions(+)

Tested-by: Naama Meir <naamax.meir@...ux.intel.com>