netdev - Re: [PATCH v4 1/1] net:rds: Fix possible deadlock in rds_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2d34a4d3934c8bf755a9f7fafb0e695829b150a.camel@redhat.com>
Date: Tue, 13 Feb 2024 10:28:10 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: allison.henderson@...cle.com, netdev@...r.kernel.org
Cc: rds-devel@....oracle.com, linux-rdma@...r.kernel.org, kuba@...nel.org, 
	edumazet@...gle.com, davem@...emloft.net, santosh.shilimkar@...cle.com
Subject: Re: [PATCH v4 1/1] net:rds: Fix possible deadlock in rds_message_put

On Thu, 2024-02-08 at 19:28 -0700, allison.henderson@...cle.com wrote:
> From: Allison Henderson <allison.henderson@...cle.com>
> 
> Functions rds_still_queued and rds_clear_recv_queue lock a given socket
> in order to safely iterate over the incoming rds messages. However
> calling rds_inc_put while under this lock creates a potential deadlock.
> rds_inc_put may eventually call rds_message_purge, which will lock
> m_rs_lock. This is the incorrect locking order since m_rs_lock is
> meant to be locked before the socket. To fix this, we move the message
> item to a local list or variable that wont need rs_recv_lock protection.
> Then we can safely call rds_inc_put on any item stored locally after
> rs_recv_lock is released.
> 
> Fixes: bdbe6fbc6a2f ("RDS: recv.c")
> Reported-by: syzbot+f9db6ff27b9bfdcfeca0@...kaller.appspotmail.com
> Reported-by: syzbot+dcd73ff9291e6d34b3ab@...kaller.appspotmail.com
> 

Note that you must avoid empty lines in the tag area. The patch LGTM,
I'll fix this while applying it, no additional actions required.

Cheers,

Paolo