netdev - Re: [PATCH v4 1/1] net:rds: Fix possible deadlock in rds_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170781782912.7605.17185434722445722969.git-patchwork-notify@kernel.org>
Date: Tue, 13 Feb 2024 09:50:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Allison Henderson <allison.henderson@...cle.com>
Cc: netdev@...r.kernel.org, rds-devel@....oracle.com,
 linux-rdma@...r.kernel.org, pabeni@...hat.com, kuba@...nel.org,
 edumazet@...gle.com, davem@...emloft.net, santosh.shilimkar@...cle.com
Subject: Re: [PATCH v4 1/1] net:rds: Fix possible deadlock in rds_message_put

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Thu,  8 Feb 2024 19:28:54 -0700 you wrote:
> From: Allison Henderson <allison.henderson@...cle.com>
> 
> Functions rds_still_queued and rds_clear_recv_queue lock a given socket
> in order to safely iterate over the incoming rds messages. However
> calling rds_inc_put while under this lock creates a potential deadlock.
> rds_inc_put may eventually call rds_message_purge, which will lock
> m_rs_lock. This is the incorrect locking order since m_rs_lock is
> meant to be locked before the socket. To fix this, we move the message
> item to a local list or variable that wont need rs_recv_lock protection.
> Then we can safely call rds_inc_put on any item stored locally after
> rs_recv_lock is released.
> 
> [...]

Here is the summary with links:
  - [v4,1/1] net:rds: Fix possible deadlock in rds_message_put
    https://git.kernel.org/netdev/net/c/f1acf1ac84d2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html