netdev - Re: [PATCH iproute2 v7 1/3] ss: add support for BPF socket-local storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f808ba38-95f4-4741-8193-43e4f2a07c3e@gmail.com>
Date: Wed, 14 Feb 2024 08:54:36 -0700
From: David Ahern <dsahern@...il.com>
To: Stephen Hemminger <stephen@...workplumber.org>,
 Quentin Deslandes <qde@...cy.de>
Cc: netdev@...r.kernel.org, Martin KaFai Lau <martin.lau@...nel.org>,
 kernel-team@...a.com, Matthieu Baerts <matttbe@...nel.org>
Subject: Re: [PATCH iproute2 v7 1/3] ss: add support for BPF socket-local
 storage

On 2/12/24 9:59 AM, Stephen Hemminger wrote:
> Some checkpatch complaints here.
> 
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #123: 
> When --bpf-maps is used, ss will send an empty INET_DIAG_REQ_SK_BPF_STORAGES
> 
> WARNING: Non-standard signature: Co-authored-by:
> #134: 
> Co-authored-by: Martin KaFai Lau <martin.lau@...nel.org>

The order should be:

Co-authored-by: Martin KaFai Lau <martin.lau@...nel.org>
Signed-off-by: Quentin Deslandes <qde@...cy.de>

since Quentin is the one sending the set and the Acked-by should be dropped.

> 
> WARNING: line length of 112 exceeds 100 columns
> #189: FILE: misc/ss.c:3417:
> +		fprintf(stderr, "ss: too many (> %u) BPF socket-local storage maps found, skipping map ID %u\n",

to be clear: printf statements should not be split across lines, so at
best this one becomes:
		fprintf(stderr,
			"ss: ..."