netdev - Re: [PATCH iproute2 v7 1/3] ss: add support for BPF socket-local storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240214191317.0a104b14@hermes.local>
Date: Wed, 14 Feb 2024 19:13:17 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: David Ahern <dsahern@...il.com>
Cc: Quentin Deslandes <qde@...cy.de>, netdev@...r.kernel.org, Martin KaFai
 Lau <martin.lau@...nel.org>, kernel-team@...a.com, Matthieu Baerts
 <matttbe@...nel.org>
Subject: Re: [PATCH iproute2 v7 1/3] ss: add support for BPF socket-local
 storage

On Wed, 14 Feb 2024 08:54:36 -0700
David Ahern <dsahern@...il.com> wrote:

> > WARNING: line length of 112 exceeds 100 columns
> > #189: FILE: misc/ss.c:3417:
> > +		fprintf(stderr, "ss: too many (> %u) BPF socket-local storage maps found, skipping map ID %u\n",  
> 
> to be clear: printf statements should not be split across lines, so at
> best this one becomes:
> 		fprintf(stderr,
> 			"ss: ..."
> 

Message could also be shortened, something like:
		fprintf(stderr,
			"Too many BPF local maps found (> %u), skipping ID %u\n",