netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 10:37:23 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, Eric Dumazet <edumazet@...gle.com>, "Nguyen,
 Anthony L" <anthony.l.nguyen@...el.com>, "Brady, Alan"
	<alan.brady@...el.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement
 modern PM ops declarations

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Jesse Brandeburg
> Sent: Sunday, February 11, 2024 3:31 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Brandeburg, Jesse <jesse.brandeburg@...el.com>; Eric Dumazet <edumazet@...gle.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Brady, Alan <alan.brady@...el.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations
>
> Switch the Intel networking drivers to use the new power management ops
> declaration formats and macros, which allows us to drop __maybe_unused,
> as well as a bunch of ifdef checking CONFIG_PM.
>
> This is safe to do because the compiler drops the unused functions,
> verified by checking for any of the power management function symbols
> being present in System.map for a build without CONFIG_PM.
>
> If a driver has runtime PM, define the ops with pm_ptr(), and if the
> driver has Simple PM, use pm_sleep_ptr(), as well as the new versions of
> the macros for declaring the members of the pm_ops structs.
>
> Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on
> x64_64.
>
> Reviewed-by: Alan Brady <alan.brady@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> e1p-v2: dropped errant idpf change, updated after v2 1/2 updates to
> move the declation down for igb_pm_ops.
> ---
>  drivers/net/ethernet/intel/e100.c             |  8 +++----
>  drivers/net/ethernet/intel/e1000/e1000_main.c | 14 +++++------
>  drivers/net/ethernet/intel/e1000e/netdev.c    | 22 +++++++----------
>  drivers/net/ethernet/intel/fm10k/fm10k_pci.c  | 10 ++++----
>  drivers/net/ethernet/intel/i40e/i40e_main.c   | 10 ++++----
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  8 +++----
>  drivers/net/ethernet/intel/igb/igb_main.c     | 24 ++++++++-----------
>  drivers/net/ethernet/intel/igbvf/netdev.c     |  6 ++---
>  drivers/net/ethernet/intel/igc/igc_main.c     | 24 +++++++------------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  8 +++----
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c |  8 +++----
>  11 files changed, 60 insertions(+), 82 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)