netdev - Re: [PATCH] json_print: Add explicit condition in print_color

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 14 Feb 2024 19:00:10 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Maks Mishin <maks.mishinfz@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] json_print: Add explicit condition in
 print_color_string()

On Tue, 13 Feb 2024 23:40:09 +0300
Maks Mishin <maks.mishinfz@...il.com> wrote:

> Added explicit condition for check `key` and `value`
> in print_color_string() to avoid call `jsonw_string_field`
> with key=NULL and value=NULL.
> 
> Signed-off-by: Maks Mishin <maks.mishinFZ@...il.com>

Thanks for the patch, but looks like another potential issue
found by a checker. Anything calling print_color_string and wanting
to print a json string with key and value of NULL is broken.
This change would paper over a real bug.

Do you have a test case where this occurs?