netdev - Re: [PATCH net-next] net: ena: Remove ena_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <407e3b7d-b0b3-4e5a-b265-462193e5b4b2@intel.com>
Date: Fri, 16 Feb 2024 14:31:37 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Kamal Heib <kheib@...hat.com>, <netdev@...r.kernel.org>, "David S .
 Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>
CC: Shay Agroskin <shayagr@...zon.com>, David Arinzon <darinzon@...zon.com>,
	Arthur Kiyanovski <akiyano@...zon.com>, Noam Dagan <ndagan@...zon.com>,
	"Saeed Bishara" <saeedb@...zon.com>
Subject: Re: [PATCH net-next] net: ena: Remove ena_select_queue



On 2/15/2024 2:31 PM, Kamal Heib wrote:
> Avoid the following warnings by removing the ena_select_queue() function
> and rely on the net core to do the queue selection, The issue happen
> when an skb received from an interface with more queues than ena is
> forwarded to the ena interface.
> 
> [ 1176.159959] eth0 selects TX queue 11, but real number of TX queues is 8
> [ 1176.863976] eth0 selects TX queue 14, but real number of TX queues is 8
> [ 1180.767877] eth0 selects TX queue 14, but real number of TX queues is 8
> [ 1188.703742] eth0 selects TX queue 14, but real number of TX queues is 8
> 
> Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
> Signed-off-by: Kamal Heib <kheib@...hat.com>
> ---

You could blindly do something like modulo the real number of queues...
but it seems like its just better to let the kernel decide.

I did check and there doesn't appear to be much of an explanation for
the select_queue implementation in the original commit either.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>