netdev - Re: [PATCH stmmac 4.19 1/2] stmmac: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f858dfa8-478e-4537-a8c5-2c16603587ee@intel.com>
Date: Fri, 16 Feb 2024 14:34:11 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: <hsimeliere.opensource@...ekio.com>, <stable@...r.kernel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Giuseppe Cavallaro
	<peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, "Jose
 Abreu" <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH stmmac 4.19 1/2] stmmac: no need to check return value of
 debugfs_create functions



On 2/15/2024 7:15 AM, hsimeliere.opensource@...ekio.com wrote:
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> [ Upstream commit 8d72ab119f42f25abb393093472ae0ca275088b6 ]
> 
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Because we don't care about the individual files, we can remove the
> stored dentry for the files, as they are not needed to be kept track of
> at all.
> 
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Cc: Jose Abreu <joabreu@...opsys.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: netdev@...r.kernel.org
> Cc: linux-stm32@...md-mailman.stormreply.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Hugo SIMELIERE <hsimeliere.opensource@...ekio.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>