netdev - Re: [PATCH net-next 10/11] net: mctp: tests: Test that outgoing skbs have flow data populated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2162cfdba3d388a94c6e8f66bdc899f1a2ca6c7.camel@codeconstruct.com.au>
Date: Sat, 17 Feb 2024 11:32:22 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Matt Johnston <matt@...econstruct.com.au>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, David Howells <dhowells@...hat.com>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, Liang Chen <liangchen.linux@...il.com>, 
 Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH net-next 10/11] net: mctp: tests: Test that outgoing
 skbs have flow data populated

Hi Jakub,

> > +static void mctp_test_packet_flow(struct kunit *test)
> > +{
> > +       kunit_skip(test, "Requires CONFIG_MCTP_FLOWS=y");
> > +}
> > +
> > +static void mctp_test_fragment_flow(struct kunit *test)
> > +{
> > +       kunit_skip(test, "Requires CONFIG_MCTP_FLOWS=y");
> > +}
> 
> These two get skipped when running:
> 
> ./tools/testing/kunit/kunit.py run --alltests
> 
> Is it possible to make all-test include the right config option
> automatically, so they can run?

Sure! I assume that's just a matter of adding to all_tests.config, and
getting the dependencies sorted. I will send an update shortly.

Would you prefer a v2 of the series, or just that one patch?

Cheers,

Jeremy