[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240219120703.219ad3b2@kernel.org>
Date: Mon, 19 Feb 2024 12:07:03 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, Boris Pismenny <borisp@...dia.com>, John
Fastabend <john.fastabend@...il.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, Vakul Garg
<vakul.garg@....com>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net 3/5] tls: don't skip over different type records
from the rx_list
On Thu, 15 Feb 2024 17:17:31 +0100 Sabrina Dubroca wrote:
> @@ -1772,7 +1772,8 @@ static int process_rx_list(struct tls_sw_context_rx *ctx,
> u8 *control,
> size_t skip,
> size_t len,
> - bool is_peek)
> + bool is_peek,
> + bool *more)
> {
> struct sk_buff *skb = skb_peek(&ctx->rx_list);
> struct tls_msg *tlm;
> @@ -1844,6 +1845,10 @@ static int process_rx_list(struct tls_sw_context_rx *ctx,
>
> out:
> return copied ? : err;
> +more:
> + if (more)
> + *more = true;
> + goto out;
Patches look correct, one small nit here -
I don't have great ideas how to avoid the 7th argument completely but
I think it'd be a little cleaner if we either:
- passed in err as an output argument (some datagram code does that
IIRC), then function can always return copied directly, or
- passed copied as an output argument, and then we can always return
err?
I like the former a little better because we won't have to special case
NULL for the "after async decryption" call sites.
Powered by blists - more mailing lists