netdev - Re: [PATCH net-next 3/3] bpf: test_run: Fix cacheline alignment of live XDP frame data structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e64a5c7b-4de3-761c-ec21-7e09a43ac440@iogearbox.net>
Date: Tue, 20 Feb 2024 10:06:31 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Toke Høiland-Jørgensen <toke@...hat.com>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] bpf: test_run: Fix cacheline alignment of
 live XDP frame data structures

On 2/15/24 2:26 PM, Toke Høiland-Jørgensen wrote:
> The live XDP frame code in BPF_PROG_RUN suffered from suboptimal cache
> line placement due to the forced cache line alignment of struct
> xdp_rxq_info. Rearrange things so we don't waste a whole cache line on
> padding, and also add explicit alignment to the data_hard_start field in
> the start-of-page data structure we use for the data pages.
> 
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>