netdev - Re: [PATCH net] net/sched: flower: Add lock protection when remove filter handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdRuJuUKALW1Xe9Q@nanopsycho>
Date: Tue, 20 Feb 2024 10:17:26 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jianbo Liu <jianbol@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net,
	Cosmin Ratiu <cratiu@...dia.com>, Gal Pressman <gal@...dia.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Cong Wang <xiyou.wangcong@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Paul Blakey <paulb@...dia.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net] net/sched: flower: Add lock protection when remove
 filter handle

Tue, Feb 20, 2024 at 09:59:28AM CET, jianbol@...dia.com wrote:
>As IDR can't protect itself from the concurrent modification, place
>idr_remove() under the protection of tp->lock.
>
>Fixes: 08a0063df3ae ("net/sched: flower: Move filter handle initialization earlier")
>Signed-off-by: Jianbo Liu <jianbol@...dia.com>
>Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
>Reviewed-by: Gal Pressman <gal@...dia.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>