netdev - Re: [PATCH net] net/sched: flower: Add lock protection when remove filter handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMkYFtP4UTTQOwhz=mfzVbVuwo0Ra1zSv6bqG8M4tzVzSg@mail.gmail.com>
Date: Tue, 20 Feb 2024 09:53:19 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Jianbo Liu <jianbol@...dia.com>, netdev@...r.kernel.org, davem@...emloft.net, 
	Cosmin Ratiu <cratiu@...dia.com>, Gal Pressman <gal@...dia.com>, Cong Wang <xiyou.wangcong@...il.com>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Simon Horman <horms@...nel.org>, Paul Blakey <paulb@...dia.com>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net] net/sched: flower: Add lock protection when remove
 filter handle

On Tue, Feb 20, 2024 at 4:17 AM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Tue, Feb 20, 2024 at 09:59:28AM CET, jianbol@...dia.com wrote:
> >As IDR can't protect itself from the concurrent modification, place
> >idr_remove() under the protection of tp->lock.
> >
> >Fixes: 08a0063df3ae ("net/sched: flower: Move filter handle initialization earlier")
> >Signed-off-by: Jianbo Liu <jianbol@...dia.com>
> >Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> >Reviewed-by: Gal Pressman <gal@...dia.com>
>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

Jianbo,  do you have a new test case that caught this that we can use?
Just curious why it hasnt been caught earlier (it's been there for
about a year).

cheers,
jamal