netdev - Re: [PATCH v2 net-next 09/14] af_unix: Skip GC if no cycle exists.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240220174747.47705-1-kuniyu@amazon.com>
Date: Tue, 20 Feb 2024 09:47:47 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <pabeni@...hat.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 09/14] af_unix: Skip GC if no cycle exists.

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 20 Feb 2024 13:56:13 +0100
> On Fri, 2024-02-16 at 13:05 -0800, Kuniyuki Iwashima wrote:
> > diff --git a/include/net/af_unix.h b/include/net/af_unix.h
> > index b3ba5e949d62..59ec8d7880ce 100644
> > --- a/include/net/af_unix.h
> > +++ b/include/net/af_unix.h
> > @@ -36,6 +36,7 @@ struct unix_vertex {
> >  	struct list_head entry;
> >  	struct list_head scc_entry;
> >  	unsigned long out_degree;
> > +	unsigned long self_degree;
> >  	unsigned long index;
> >  	unsigned long lowlink;
> >  };
> 
> The series increases considerably struct unix_sock size. Have you
> considered dynamically allocating unix_vertex only when using
> SCM_RIGTHS?

Ah good point.
Will try to do that in v3.

Thanks!