netdev - Re: [PATCH v2 net-next 03/14] af_unix: Link struct unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <778159a764a93074ee5357ea37216183a185a390.camel@redhat.com>
Date: Tue, 20 Feb 2024 18:53:14 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 kuni1840@...il.com,  netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 03/14] af_unix: Link struct unix_edge when
 queuing skb.

On Tue, 2024-02-20 at 09:44 -0800, Kuniyuki Iwashima wrote:
> From: Paolo Abeni <pabeni@...hat.com>
> Date: Tue, 20 Feb 2024 13:06:18 +0100
> > Here  'edge->predecessor->entry' and 'edge->entry' refer to different
> > object types right ? edge vs vertices. Perhaps using different field
> > names could clarify the code a bit? 
> 
> Regarding the name of edge->entry, I agree a diffrent name would be
> easy to understand.  I'll rename it to edge->vertex_entry unless there
> is a better name :)

[side note: thanks for copying with my reply mistake!] 

vertex_entry WFM! but please note that I'm quite bad ad peeking
variables names ;)

Cheers,

Paolo