netdev - Re: [PATCH 2/2] [v2] net/mlx5: fix possible stack overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <726459a9-c549-4fec-9a4d-61ae1da04f0a@app.fastmail.com>
Date: Tue, 20 Feb 2024 09:11:51 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Simon Horman" <horms@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Saeed Mahameed" <saeedm@...dia.com>, "Leon Romanovsky" <leon@...nel.org>,
 "Zhu Yanjun" <yanjun.zhu@...ux.dev>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, "Yevgeny Kliteynik" <kliteyn@...dia.com>,
 "Alex Vesker" <valex@...dia.com>, "Hamdan Igbaria" <hamdani@...dia.com>,
 Netdev <netdev@...r.kernel.org>, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] [v2] net/mlx5: fix possible stack overflows

On Tue, Feb 20, 2024, at 09:06, Simon Horman wrote:
> On Mon, Feb 19, 2024 at 11:04:56AM +0100, Arnd Bergmann wrote:

> Hi Arnd,
>
> With patch 1/2 in place this code goes on as:
>
> 	switch (action->action_type) {
> 	case DR_ACTION_TYP_DROP:
> 		memset(buff, 0, sizeof(buff));
>
> buff is now a char * rather than an array of char.
> siceof(buff) doesn't seem right here anymore.
>
> Flagged by Coccinelle.

Rihgt, that would be bad. It sounds like we won't use patch 1/2
after all though, so I think it's going to be fine after all.
If the mlx5 maintainers still want both patches, I'll rework
it to use the fixed size.

     Arnd