netdev - Re: [PATCH 2/2] [v2] net/mlx5: fix possible stack overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461d3ede-5d34-449e-8115-1c4558ae31a2@nvidia.com>
Date: Tue, 20 Feb 2024 10:21:34 +0200
From: Yevgeny Kliteynik <kliteyn@...dia.com>
To: Arnd Bergmann <arnd@...db.de>, Simon Horman <horms@...nel.org>,
 Arnd Bergmann <arnd@...nel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Zhu Yanjun <yanjun.zhu@...ux.dev>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Alex Vesker <valex@...dia.com>,
 Hamdan Igbaria <hamdani@...dia.com>, Netdev <netdev@...r.kernel.org>,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] [v2] net/mlx5: fix possible stack overflows

On 20-Feb-24 10:11, Arnd Bergmann wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Feb 20, 2024, at 09:06, Simon Horman wrote:
>> On Mon, Feb 19, 2024 at 11:04:56AM +0100, Arnd Bergmann wrote:
> 
>> Hi Arnd,
>>
>> With patch 1/2 in place this code goes on as:
>>
>>        switch (action->action_type) {
>>        case DR_ACTION_TYP_DROP:
>>                memset(buff, 0, sizeof(buff));
>>
>> buff is now a char * rather than an array of char.
>> siceof(buff) doesn't seem right here anymore.
>>
>> Flagged by Coccinelle.
> 
> Rihgt, that would be bad. It sounds like we won't use patch 1/2
> after all though, so I think it's going to be fine after all.
> If the mlx5 maintainers still want both patches, I'll rework
> it to use the fixed size.

No need for the first patch, so only the stack frame limit
fix is needed.

Thanks,

-- YK

>       Arnd