netdev - Re: [PATCH ver.2] gtp: fix use-after-free and null-ptr-deref in gtp_genl_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdXUrV5YwIXnRI8u@calendula>
Date: Wed, 21 Feb 2024 11:47:09 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: kovalev@...linux.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, edumazet@...gle.com, laforge@...monks.org,
	davem@...emloft.net, pabeni@...hat.com, nickel@...linux.org,
	oficerovas@...linux.org, dutyrok@...linux.org,
	stable@...r.kernel.org
Subject: Re: [PATCH ver.2] gtp: fix use-after-free and null-ptr-deref in
 gtp_genl_dump_pdp()

On Tue, Feb 20, 2024 at 04:04:34PM -0800, Jakub Kicinski wrote:
> On Thu, 15 Feb 2024 18:43:46 +0100 Pablo Neira Ayuso wrote:
> > > Yes, I can prepare several patches with the same commit message. Is it
> > > better to send them individually (like this patch) or in a series with a
> > > brief preliminary description (PATCH 0/x)?  
> > 
> > I'd suggest one patch for each subsystem as per MAINTAINER file, that
> > should also make it easier for Linux kernel -stable maintainers to
> > pick up this fix series.
> 
> Pablo is anything expected to change from gtp patch itself?
> Someone (DaveM?) marked this as Changes Requested but I don't see 
> a clear ask, other that to follow up with patches to other families.

Thanks for your follow up.

It would be good if this patch gets a Fixes: tag. I'd suggest:

Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")

Meanwhile a v3 is sent, I am going to test it so I can provide a
Testbed-by: tag for you.