[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240221111444.22fce1f7@kernel.org>
Date: Wed, 21 Feb 2024 11:14:44 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: Russell King <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose
Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
Clément Léger <clement.leger@...tlin.com>, Maxime
Chevallier <maxime.chevallier@...tlin.com>, Miquel Raynal
<miquel.raynal@...tlin.com>, Thomas Petazzoni
<thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
Clark Wang <xiaoning.wang@....com>
Subject: Re: [PATCH net-next v4 5/7] net: stmmac: Signal to PHY/PCS drivers
to keep RX clock on
On Wed, 21 Feb 2024 14:04:22 +0100 Romain Gantois wrote:
> There is a reocurring issue with stmmac controllers where the MAC fails to
> initialize its hardware if an RX clock signal isn't provided on the MAC/PHY
> link.
>
> This causes issues when PHY or PCS devices either go into suspend while
> cutting the RX clock or do not bring the clock signal up early enough for
> the MAC to initialize successfully.
>
> Set the mac_requires_rxc flag in the stmmac phylink config so that PHY/PCS
> drivers know to keep the RX clock up at all times.
>
> Reported-by: Clark Wang <xiaoning.wang@....com>
> Link: https://lore.kernel.org/all/20230202081559.3553637-1-xiaoning.wang@nxp.com/
> Reported-by: Clément Léger <clement.leger@...tlin.com>
> Link: https://lore.kernel.org/linux-arm-kernel/20230116103926.276869-4-clement.leger@bootlin.com/
> Suggested-by: Russell King <linux@...linux.org.uk>
> Signed-off-by: Romain Gantois <romain.gantois@...tlin.com>
breaks allmodconfig:
ERROR: modpost: "phylink_pcs_pre_init" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined!
--
pw-bot: cr
Powered by blists - more mailing lists