[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240221191752.GA68788@fastly.com>
Date: Wed, 21 Feb 2024 11:17:53 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
Jesper Dangaard Brouer <hawk@...nel.org>,
Stanislav Fomichev <sdf@...gle.com>,
Amritha Nambiar <amritha.nambiar@...el.com>,
Larysa Zaremba <larysa.zaremba@...el.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Tariq Toukan <tariqt@...dia.com>,
Sridhar Samudrala <sridhar.samudrala@...el.com>,
Alexei Starovoitov <ast@...nel.org>,
Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH net-next 1/2] netdev-genl: Add ifname for queue and NAPI
APIs
On Wed, Feb 21, 2024 at 11:12:20AM -0800, Jakub Kicinski wrote:
> On Wed, 21 Feb 2024 07:57:29 -0800 Joe Damato wrote:
> > if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_ID) ||
> > GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_TYPE) ||
> > - GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX))
> > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX) ||
> > + GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFNAME))
>
> This means user always has to provide both ifindex and ifname,
> right?
That's right. I'm OK with omitting this requirement, though. I feel like to
your earlier point on name changes, maybe ifindex is enough as far as
required params go.
Powered by blists - more mailing lists