netdev - Re: [PATCH iwl-net v1] ice: fix NULL pointer access during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd289ca9-0689-5cbc-a088-72f8efa8cb8e@intel.com>
Date: Thu, 22 Feb 2024 14:25:07 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Elliott, Rob"
	<elliott@....com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [PATCH iwl-net v1] ice: fix NULL pointer access during resume



On 2/22/2024 2:19 PM, Keller, Jacob E wrote:

>> -----Original Message-----
>> From: Nguyen, Anthony L <anthony.l.nguyen@...el.com>

...

>>> NOTE:
>>> Requires Amritha's patch:
>>> https://patchwork.ozlabs.org/project/intel-wired-
>> lan/patch/170785373072.3325.9129916579186572531.stgit@...mbiarhost.jf.
>> intel.com/
>>> to be applied before this will pass testing cleanly.
>>
>> I think this may be the other way around? It looks to be clean for
>> netdev (doesn't have Amritha's patch), but it's not applying to
>> net-queue (has Amritha's patch).
>>
>>   > base-commit: 23f9c2c066e7e5052406fb8f04a115d3d0260b22
>>
>> Base commit also seems to be a netdev commit.
>>
>> Since Amritha's patch is pending to netdev [1], I think we need a
>> version that will apply with Amritha's changes.
>>
>> Thanks,
>> Tony
>>
>>
>> [1]
>> https://lore.kernel.org/netdev/20240220214444.1039759-7-
>> anthony.l.nguyen@...el.com/
> 
> I think he means that the tests won't pass without Amritha's patch because we'll hit the ASSERT_RTNL in the suspend flow otherwise.

Got it. Anyways, this doesn't apply to net-queue, could we rebase or 
base it off of that tree?

Thanks,
Tony

> Thanks,
> Jake