netdev - Re: [Intel-wired-lan] [PATCH iwl-net 0/3] intel: fix routines that disable queue pairs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 22 Feb 2024 09:32:06 +0100
From: Magnus Karlsson <magnus.karlsson@...il.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, 
	anthony.l.nguyen@...el.com, magnus.karlsson@...el.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 0/3] intel: fix routines that
 disable queue pairs

On Tue, 20 Feb 2024 at 22:46, Maciej Fijalkowski
<maciej.fijalkowski@...el.com> wrote:
>
> Hi,
>
> It started out as an issue on ixgbe reported by Pavel [0] which first
> patch is supposed to fix, but apparently i40e and ice have queue pair
> disabling flow a bit out of order, so I addressed them as well. More
> info is included in commit messages.
>
> FWIW we are talking here about AF_XDP ZC when xsk_pool is sent down to
> driver. Typically these routines are executed when there is already XDP
> program running on interface.
>
> Thanks!
>
> [0]: https://lore.kernel.org/netdev/CAJEV1ijxNyPTwASJER1bcZzS9nMoZJqfR86nu_3jFFVXzZQ4NA@mail.gmail.com/

Thank you for this fix Maciej.

Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>

> Maciej Fijalkowski (3):
>   ixgbe: {dis,en}able irqs in ixgbe_txrx_ring_{dis,en}able
>   i40e: disable NAPI right after disabling irqs when handling xsk_pool
>   ice: reorder disabling IRQ and NAPI in ice_qp_dis
>
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  2 +-
>  drivers/net/ethernet/intel/ice/ice_xsk.c      |  9 +--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 56 ++++++++++++++++---
>  3 files changed, 55 insertions(+), 12 deletions(-)
>
> --
> 2.34.1
>