netdev - Re: [PATCH 5/6] net: hns3: Remove io_stop_wc() calls after __iowrite64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ac5429-df48-489e-928f-8444aea127cd@huawei.com>
Date: Thu, 22 Feb 2024 08:57:12 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Jason Gunthorpe <jgg@...dia.com>, Alexander Gordeev
	<agordeev@...ux.ibm.com>, Andrew Morton <akpm@...ux-foundation.org>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>, Borislav Petkov
	<bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Gerald Schaefer
	<gerald.schaefer@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Heiko
 Carstens <hca@...ux.ibm.com>, "H. Peter Anvin" <hpa@...or.com>, Justin Stitt
	<justinstitt@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Leon Romanovsky
	<leon@...nel.org>, <linux-rdma@...r.kernel.org>,
	<linux-s390@...r.kernel.org>, <llvm@...ts.linux.dev>, Ingo Molnar
	<mingo@...hat.com>, Bill Wendling <morbo@...gle.com>, Nathan Chancellor
	<nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>,
	<netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>, Salil Mehta
	<salil.mehta@...wei.com>, Sven Schnelle <svens@...ux.ibm.com>, Thomas
 Gleixner <tglx@...utronix.de>, <x86@...nel.org>, Yisen Zhuang
	<yisen.zhuang@...wei.com>
CC: <shaojijie@...wei.com>, Arnd Bergmann <arnd@...db.de>, Catalin Marinas
	<catalin.marinas@....com>, Leon Romanovsky <leonro@...lanox.com>,
	<linux-arch@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, Mark
 Rutland <mark.rutland@....com>, Michael Guralnik <michaelgur@...lanox.com>,
	<patches@...ts.linux.dev>, Niklas Schnelle <schnelle@...ux.ibm.com>, Will
 Deacon <will@...nel.org>
Subject: Re: [PATCH 5/6] net: hns3: Remove io_stop_wc() calls after
 __iowrite64_copy()

Reviewed-by: Jijie Shao<shaojijie@...wei.com>

on 2024/2/21 9:17, Jason Gunthorpe wrote:
> Now that the ARM64 arch implementation does the DGH as part of
> __iowrite64_copy() there is no reason to open code this in drivers.
>
> Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
> ---
>   drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index f1695c889d3a07..ff556c2b5bacb4 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -2068,8 +2068,6 @@ static void hns3_tx_push_bd(struct hns3_enet_ring *ring, int num)
>   	__iowrite64_copy(ring->tqp->mem_base, desc,
>   			 (sizeof(struct hns3_desc) * HNS3_MAX_PUSH_BD_NUM) /
>   			 HNS3_BYTES_PER_64BIT);
> -
> -	io_stop_wc();
>   }
>   
>   static void hns3_tx_mem_doorbell(struct hns3_enet_ring *ring)
> @@ -2088,8 +2086,6 @@ static void hns3_tx_mem_doorbell(struct hns3_enet_ring *ring)
>   	u64_stats_update_begin(&ring->syncp);
>   	ring->stats.tx_mem_doorbell += ring->pending_buf;
>   	u64_stats_update_end(&ring->syncp);
> -
> -	io_stop_wc();
>   }
>   
>   static void hns3_tx_doorbell(struct hns3_enet_ring *ring, int num,